Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scrap to false positives #37

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Add scrap to false positives #37

merged 1 commit into from
Aug 11, 2022

Conversation

tbantle22
Copy link
Contributor

Summary

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Added the documentation in README.md, if applicable.

@codecov-commenter
Copy link

Codecov Report

Merging #37 (a0bf8d6) into master (d92629b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files           1        1           
  Lines         191      191           
=======================================
  Hits          190      190           
  Misses          1        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TwiN
Copy link
Owner

TwiN commented Aug 11, 2022

I guess this is most likely going to cause issues with sentences like "this is crap", which would be sanitized as "thisiscrap", but IMHO, "crap" isn't much of a profanity to begin with, so I'm fine with this type of false positive.

Worst case scenario, we'll have to add a few false negatives in the future.

@TwiN TwiN merged commit 5cdcd94 into TwiN:master Aug 11, 2022
@TwiN TwiN added the bug Something isn't working label Aug 11, 2022
@TwiN
Copy link
Owner

TwiN commented Aug 11, 2022

Thank you for the contribution!

@TwiN
Copy link
Owner

TwiN commented Aug 11, 2022

Released in v1.6.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants